Expand description
This crate contains an assortment of utilities to deal with paths and their conversions.
Generally git treats paths as bytes, but inherently assumes non-illformed UTF-8 as encoding on windows. Internally, it expects
slashes to be used as path separators and paths in files must have slashes, with conversions being performed on windows accordingly.
Research
- windows
dirent.ccontains all implementation (seemingly) of opening directories and reading their entries, along with all path conversions (UTF-16 for windows). This is done on the fly so git can work with in UTF-8.- mingw is used for the conversion and it appears they handle surrogates during the conversion, maybe some sort of non-strict UTF-8 converter? Actually it uses WideCharToMultiByte under the hood which by now does fail if the UTF-8 would be invalid unicode, i.e. unicode pairs.
OsStringon windows already stores strings as WTF-8, which supports surrogate pairs, something that UTF-8 isn’t allowed do it for security reasons, after all it’s UTF-16 specific and exists only to extend the encodable code-points.- informative reading on WTF-8 which is the encoding used by Rust internally that deals with surrogates and non-wellformed surrogates (those that aren’t in pairs).
- unix
- It uses opendir and readdir respectively. There is no encoding specified, except that these paths are null-terminated.
Learnings
Surrogate pairs are a way to extend the encodable value range in UTF-16 encodings, used primarily on windows and in Javascript. For a long time these codepoints used for surrogates, always to be used in pairs, were not assigned, until…they were for rare emojies and the likes. The unicode standard does not require surrogates to happen in pairs, even though by now unpaired surrogates in UTF-16 are considered ill-formed, which aren’t supposed to be converted to UTF-8 for example.
This is the reason we have to deal with to_string_lossy(), it’s just for that quirk.
This also means the only platform ever eligible to see conversion errors is windows, and there it’s only older pre-vista windows versions which incorrectly allow ill-formed UTF-16 strings. Newer versions don’t perform such conversions anymore, for example when going from UTF-16 to UTF-8, they will trigger an error.
Conclusions
Since WideCharToMultiByte by now is
fixed (Vista onward) to produce valid UTF-8, lone surrogate codepoints will cause failure, which git
doesn’t care about.
We will, though, which means from now on we can just convert to UTF-8 on windows and bubble up errors where necessary, preventing potential mismatched surrogate pairs to ever be saved on disk by gitoxide.
Even though the error only exists on older windows versions, we will represent it in the type system through fallible function calls.
Callers may .expect() on the result to indicate they don’t wish to handle this special and rare case. Note that servers should not
ever get into a code-path which does panic though.
Modules
Structs
A dummy type to represent path specs and help finding all spots that take path specs once it is implemented. A preliminary version of a path-spec based on glances of the code.
The error type returned by into_bstr() and others may suffer from failed conversions from or to bytes.
Functions
Resolve relative components virtually without accessing the file system, e.g. turn a/./b/c/.././.. into a,
without keeping intermediate .. and /a/../b/.. becomes /.
Note that we might access the current_dir if we run out of path components to pop off. If unset, we continue
which might lead to an invalid/uninteded path.
Similar to try_from_bstr(), but panics if malformed surrogates are encountered on windows.
Similar to try_from_bstring(), but will panic if there is ill-formed UTF-8 in the input.
Similar to try_from_byte_slice(), but will panic if there is ill-formed UTF-8 in the input.
Similar to try_into_bstr() but panics if malformed surrogates are encountered on windows.
Like into_bstr(), but takes OsStr as input for a lossless, but fallible, conversion.
Convert paths with slashes to backslashes on windows and do nothing on unix, but panics if malformed surrogates are encountered on windows.
Assures the given bytes use the native path separator.
Replaces windows path separators with slashes, unconditionally.
Replaces windows path separators with slashes, but only do so on windows.
Find backslashes and replace them with slashes, which typically resembles a unix path, unconditionally.
Similar to from_byte_slice(), but takes either borrowed or owned input.
Similar to try_from_bstr(), but takes and produces owned data.
Given input bytes, produce a Path from them ignoring encoding entirely if on unix.
Convert the given path either into its raw bytes on unix or its UTF8 encoded counterpart on windows.